-
Notifications
You must be signed in to change notification settings - Fork 113
fix: license header for Pyright language server #4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
|
@aglinxinyuan can you open a new issue for this change? We want to include the issue in #4080. |
The issue is described in PR #3415. Can we use PR #3415 as a reference? |
PJ describes the issue in the reply to PR #3415. Since it is confusing, I will create an issue. Issue #4133 |
|
@aglinxinyuan : @bobbai00 is traveling and may have limited availability. Besides him, can you recommend another committer to review it? |
@Yicong-Huang can review it. |
Remove pyright-language-service license header changes as they are already addressed in PR apache#4132. This commit now focuses only on: - mbknor-jackson-jsonschema (MIT license attribution) - Angular array.type.ts (MIT license attribution) - sbt-license-report plugin for dependency tracking
|
I will close this one. #4134 will handle all changes related to license header restoration |
…4134) <!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? The third-party code (all MIT licensed, Category A) is compatible with Apache License 2.0 but requires proper attribution per Apache policy. This PR addresses license compliance issues identified during an audit: MIT License Headers Restored: - com/kjetland/** - mbknor-jackson-jsonschema (MIT) - frontend/src/app/common/formly/*.ts - Google Angular examples (MIT) - pyright-language-service/src/*.ts - TypeFox monaco-languageclient (MIT) - Replaced CC-BY 3.0 icons with MIT-licensed alternatives from SVGRepo - Removed `hub_icon.svg` (which is from Shutterstock using incompatible license) LICENSE File: - Added third-party attribution section grouped by license type - Added licenses/LICENSE-MIT.txt Config: - Updated .licenserc.yaml to exclude third-party files from Apache header checks References: - [Apache licensing-howto: Bundling permissively-licensed dependencies](https://infra.apache.org/licensing-howto.html#permissive-deps) - [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html) ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234` or `Closes #1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> Closes #4135. Related to #4132. ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Manual verified. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> Co-authored with Claude code. --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Chen Li <[email protected]>
What changes were proposed in this PR?
Remove the Apache header and add back the MIT header for 3rd-party source files.
Any related issues, documentation, discussions?
Fixes #4133
Was this PR authored or co-authored using generative AI tooling?
No.